Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds divider to toolbars with destructive actions #12895

Merged
merged 2 commits into from
Oct 22, 2021
Merged

adds divider to toolbars with destructive actions #12895

merged 2 commits into from
Oct 22, 2021

Conversation

zofskeez
Copy link
Contributor

To maintain a consistent toolbar layout, any destructive actions should appear to the left followed by a divider. While this pattern was partially employed, this PR aims to update the remaining instances.

image

@zofskeez zofskeez added the ui label Oct 21, 2021
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 21, 2021 18:38 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 21, 2021 18:38 Inactive
@zofskeez zofskeez added this to the 1.9 milestone Oct 21, 2021
arnav28
arnav28 approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@arnav28 arnav28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!! 👍

@zofskeez zofskeez merged commit 4d4b37b into main Oct 22, 2021
@zofskeez zofskeez deleted the ui/toolbar-updates branch October 22, 2021 14:11
@Monkeychip Monkeychip mentioned this pull request Nov 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnav28 arnav28 arnav28 approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.
2 participants
@zofskeez @arnav28